Test vanilla event loop windows #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows can't interrupt the underlying syscall so we have to yield control to the python interpreter to detect ctrl-c once in a while
…till causes problems
Merged
…event-loop-windows
…event-loop-windows
…event-loop-windows
freider
commented
Feb 10, 2025
| @@ -5,6 +5,9 @@ | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(sys.version_info >= (3, 13), reason="gevent seems broken on Python 3.13") | |||
| @pytest.mark.skipif( | |||
| sys.platform == "win32", reason="gevent support broken on Windows, probably due to event loop patching" | |||
| ) | |||
There was a problem hiding this comment.
tbh, not sure how important gevent support is these days, but maybe there are still libraries making use of it?
I feel I'd rather have synchronicity be on the default event loop implementation to prevent potential inconsistencies of using a different one?
|
@mwaskom any feedback on this windows-specific (un-)patch? Any idea how prolific gevent usage is these days? |
No idea really. Seems to still get a lot of downloads from PyPI, though that's hard to interpret: https://pypistats.org/packages/gevent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been overriding which event loop implementation to use on windows due to some issues with shutdown emitting junk tracebacks, but with the recent improvements in cancellation synchronization we might have fixed this issue in a better way and could potentially got back to the default event loop on windows.